linux-kernel - Re: [PATCH v1 2/3] of: Add support for reading a s32 from a multi-value property.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1471639654.4611.2.camel@infradead.org>
Date:   Fri, 19 Aug 2016 21:47:34 +0100
From:   David Woodhouse <dwmw2@...radead.org>
To:     Heiko Stuebner <heiko@...ech.de>
Cc:     Finlye Xiao <finley.xiao@...k-chips.com>,
        srinivas.kandagatla@...aro.org, maxime.ripard@...e-electrons.com,
        robh+dt@...nel.org, frowand.list@...il.com, sre@...nel.org,
        dbaryshkov@...il.com, mark.rutland@....com, khilman@...nel.org,
        nm@...com, rjw@...ysocki.net, viresh.kumar@...aro.org,
        sboyd@...eaurora.org, linux-arm-kernel@...ts.infradead.org,
        linux-rockchip@...ts.infradead.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-pm@...r.kernel.org,
        wxt@...k-chips.com, jay.xu@...k-chips.com,
        rocky.hao@...k-chips.com, tim.chen@...k-chips.com,
        tony.xie@...k-chips.com, ulysses.huang@...k-chips.com,
        lin.huang@...k-chips.com
Subject: Re: [PATCH v1 2/3] of: Add support for reading a s32 from a
 multi-value property.

On Fri, 2016-08-19 at 22:41 +0200, Heiko Stuebner wrote:
> 
> > So no, don't *add* any more of these functions. Only add the generic
> > version. And if your driver isn't using the generic property
> > functions... fix it.
> 
> As far as I can see, all the device_property_* functions are grounded on their
> of_property_*, acpi_property_* etc counterparts and functions reading specific
> elements (the _index variants) are currently not available at all.
> 
> drivers/base/property.c:
> #define OF_DEV_PROP_READ_ARRAY(node, propname, type, val, nval)                         \
>         (val) ? of_property_read_##type##_array((node), (propname), (val), (nval))      \
>               : of_property_count_elems_of_size((node), (propname), sizeof(type))
> 
> So even if you're using the device_property_* functions you'd still need
> a match in the underlying functions or am I missing something?

Yes, but the underlying function should never be used directly by
drivers. And should probably be prefixed with __ or marked deprecated
(with an override in its one genuine call site).

-- 
dwmw2



Download attachment "smime.p7s" of type "application/x-pkcs7-signature" (5760 bytes)