linux-kernel - Re: [PATCH] smc91c92_cs : add a spinlock to avoid race condition

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20160818.210734.1003452853595787957.davem@davemloft.net>
Date:   Thu, 18 Aug 2016 21:07:34 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     andrianov@...ras.ru
Cc:     mugunthanvnm@...com, a@...table.cc, felipe.balbi@...ux.intel.com,
        fw@...len.de, netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        vaishali.thakkar@...cle.com, ldv-project@...uxtesting.org
Subject: Re: [PATCH] smc91c92_cs : add a spinlock to avoid race condition

From: Pavel Andrianov <andrianov@...ras.ru>
Date: Tue, 16 Aug 2016 16:39:06 +0300

> smc_reset may be executed in parallel with timer function media_check.
> To avoid data race in smc_set_xcvr a spinlock was added.
> 
> Found by Linux Driver Verification project (linuxtesting.org).
> 
> Signed-off-by: Pavel Andrianov <andrianov@...ras.ru>

This is not sufficient.

You have to block basically the entire function, because both
smc_reset and media_check program the bank selection so could
corrupt eachother's register accesses.