linux-kernel - Re: [PATCH] net: thunderx: Fix OOPs with ethtool --register-dump

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20160818.211655.897588198741403986.davem@davemloft.net>
Date:   Thu, 18 Aug 2016 21:16:55 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     ddaney.cavm@...il.com
Cc:     netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        sgoutham@...ium.com, rric@...nel.org,
        linux-arm-kernel@...ts.infradead.org, david.daney@...ium.com,
        stable@...r.kernel.org
Subject: Re: [PATCH] net: thunderx: Fix OOPs with ethtool --register-dump

From: David Daney <ddaney.cavm@...il.com>
Date: Tue, 16 Aug 2016 12:28:17 -0700

> From: David Daney <david.daney@...ium.com>
> 
> The ethtool_ops .get_regs function attempts to read the nonexistent
> register NIC_QSET_SQ_0_7_CNM_CHG, which produces a "bus error" type
> OOPs.
> 
> Fix by not attempting to read, and removing the definition of,
> NIC_QSET_SQ_0_7_CNM_CHG.  A zero is written into the register dump to
> keep the layout unchanged.
> 
> Signed-off-by: David Daney <david.daney@...ium.com>

Applied.