linux-kernel - Re: [PATCH 1/1] drm/amdgpu/gmc7: remove dead code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6fe073a3-3b0f-5c00-21fb-c248a0196f85@gmx.de>
Date:   Sun, 21 Aug 2016 20:45:21 +0200
From:   Heinrich Schuchardt <xypron.glpk@....de>
To:     Joe Perches <joe@...ches.com>,
        Alex Deucher <alexander.deucher@....com>,
        Christian König <christian.koenig@....com>
Cc:     David Airlie <airlied@...ux.ie>,
        Chunming Zhou <David1.Zhou@....com>,
        Ken Wang <Qingqing.Wang@....com>,
        Tom St Denis <tom.stdenis@....com>,
        dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] drm/amdgpu/gmc7: remove dead code

On 08/21/2016 08:29 PM, Joe Perches wrote:
> On Sun, 2016-08-21 at 20:06 +0200, Heinrich Schuchardt wrote:
>> In an if block for (running == 0) running cannot be non-zero.
> 
> This code could also be better unindented by one level
> (all of the block would fit 80 columns) by changing:
> 
> 	if (running == 0) {
> 		[code...]
> 	}
> 
> 	return 0;
> 
> to:
> 
> 	if (running)
> 		return 0;
> 
> 	[code...]
> 
> 	return 0;

Should I revise my patch?
Or should this be an additional patch?