linux-kernel - Re: [PATCH v1 02/10] documentation: Add scheduler/sched-avg.txt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a4a9e3ac-dbb1-9860-88c9-20ec795eafb7@infradead.org>
Date:   Mon, 22 Aug 2016 09:48:51 -0700
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Yuyang Du <yuyang.du@...el.com>, peterz@...radead.org,
        mingo@...nel.org, linux-kernel@...r.kernel.org
Cc:     bsegall@...gle.com, pjt@...gle.com, morten.rasmussen@....com,
        vincent.guittot@...aro.org, dietmar.eggemann@....com,
        matt@...eblueprint.co.uk, umgwanakikbuti@...il.com
Subject: Re: [PATCH v1 02/10] documentation: Add scheduler/sched-avg.txt

On 08/09/16 17:14, Yuyang Du wrote:
> This doc file has the program to generate the constants to compute
> sched averages.
> 
> Signed-off-by: Yuyang Du <yuyang.du@...el.com>
> ---
>  Documentation/scheduler/sched-avg.txt |   94 +++++++++++++++++++++++++++++++++
>  1 file changed, 94 insertions(+)
>  create mode 100644 Documentation/scheduler/sched-avg.txt

I'll confirm that it builds and generates a buildable source file
as long as "u32" is understood (defined/typedef'd).

I would rather see it in tools/ as a C source file with comments as
follows:

// The following program is used to generate the constants for
// computing sched averages.

//	C program (compile with -lm)

> +#include <math.h>
> +#include <stdio.h>

Maybe even add
#include <stdint.h>

and
typedef uint32_t	u32;


thanks,
-- 
~Randy