linux-kernel - Re: [PATCH v05 27/72] linux/if.h linux/hdlc/ioctl.h: move IFNAMSIZ definition to hdlc/ioctl.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20160823.000514.536168139289568958.davem@davemloft.net>
Date:   Tue, 23 Aug 2016 00:05:14 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     fransklaver@...il.com
Cc:     mikko.rapeli@....fi, linux-kernel@...r.kernel.org,
        zhangshengju@...s.chinamobile.com
Subject: Re: [PATCH v05 27/72] linux/if.h linux/hdlc/ioctl.h: move IFNAMSIZ
 definition to hdlc/ioctl.h

From: Frans Klaver <fransklaver@...il.com>
Date: Tue, 23 Aug 2016 09:03:20 +0200

> On Tue, Aug 23, 2016 at 1:30 AM, David Miller <davem@...emloft.net> wrote:
>> From: Mikko Rapeli <mikko.rapeli@....fi>
>> Date: Mon, 22 Aug 2016 20:32:44 +0200
>>
>>> Fixes userspace compiler error:
>>>
>>> error: ‘IFNAMSIZ’ undeclared here (not in a function)
>>>
>>> Suggested by Frans Klaver <fransklaver@...il.com> on lkml message
>>> <20150530195223.GA15645@...ger.home>.
>>>
>>> Signed-off-by: Mikko Rapeli <mikko.rapeli@....fi>
>>
>> IFNAMSIZ has to be in linux/if.h, you aren't explaining why you have
>> to move it to the hdlc header instead of having the hdlc header
>> include linux/if.h
> 
> Circular references. linux/if.h includes hdlc/ioctl.h, and has to
> define IFNAMSIZ before doing so.

That's not acceptable.  Use forward declarations or similar to avoid
the circular dependency.

IFNAMSIZ belongs in linux/if.h, please keep it there.