linux-kernel - Re: [PATCH v05 27/72] linux/if.h linux/hdlc/ioctl.h: move IFNAMSIZ definition to hdlc/ioctl.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAH6sp9NNLsQNgt6O0HFvd_e4JmHox2TcB6rmiV-wkwALQxYkZg@mail.gmail.com>
Date:   Tue, 23 Aug 2016 09:03:20 +0200
From:   Frans Klaver <fransklaver@...il.com>
To:     David Miller <davem@...emloft.net>
Cc:     Mikko Rapeli <mikko.rapeli@....fi>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        zhangshengju@...s.chinamobile.com
Subject: Re: [PATCH v05 27/72] linux/if.h linux/hdlc/ioctl.h: move IFNAMSIZ
 definition to hdlc/ioctl.h

On Tue, Aug 23, 2016 at 1:30 AM, David Miller <davem@...emloft.net> wrote:
> From: Mikko Rapeli <mikko.rapeli@....fi>
> Date: Mon, 22 Aug 2016 20:32:44 +0200
>
>> Fixes userspace compiler error:
>>
>> error: ‘IFNAMSIZ’ undeclared here (not in a function)
>>
>> Suggested by Frans Klaver <fransklaver@...il.com> on lkml message
>> <20150530195223.GA15645@...ger.home>.
>>
>> Signed-off-by: Mikko Rapeli <mikko.rapeli@....fi>
>
> IFNAMSIZ has to be in linux/if.h, you aren't explaining why you have
> to move it to the hdlc header instead of having the hdlc header
> include linux/if.h

Circular references. linux/if.h includes hdlc/ioctl.h, and has to
define IFNAMSIZ before doing so. If IFNAMSIZ is moved to hdlc/ioctl.h,
it is still pulled in if one includes linux/if.h. What we gain is that
you can include hdlc/ioctl.h directly (which is what one of the tests
is already doing, iirc).

But yes, it should be explained in the commit message.

Thanks,
Frans