linux-kernel - Re: [PATCH 4/7] fs: make remaining filesystems use .rename2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 23 Aug 2016 13:30:35 -0400
From:   Mike Marshall <hubcap@...ibond.com>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     Miklos Szeredi <mszeredi@...hat.com>,
        linux-fsdevel <linux-fsdevel@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Al Viro <viro@...iv.linux.org.uk>,
        Eric Van Hensbergen <ericvh@...il.com>,
        David Howells <dhowells@...hat.com>,
        Ilya Dryomov <idryomov@...il.com>,
        Jan Harkes <jaharkes@...cmu.edu>,
        Tyler Hicks <tyhicks@...onical.com>,
        Boaz Harrosh <ooo@...ctrozaur.com>,
        Oleg Drokin <oleg.drokin@...el.com>,
        Trond Myklebust <trond.myklebust@...marydata.com>,
        Mark Fasheh <mfasheh@...e.com>
Subject: Re: [PATCH 4/7] fs: make remaining filesystems use .rename2

I looked at this in today's linux-next and ran a few renames through...

Acked-by:: Mike Marshall <hubcap@...ibond.com>

On Tue, Aug 23, 2016 at 10:47 AM, Greg Kroah-Hartman
<gregkh@...uxfoundation.org> wrote:
> On Tue, Aug 23, 2016 at 04:05:29PM +0200, Miklos Szeredi wrote:
>> This is trivial to do:
>>
>>  - add flags argument to foo_rename()
>>  - check if flags is zero
>>  - assign foo_rename() to .rename2 instead of .rename
>>
>> This doesn't mean it's impossible to support RENAME_NOREPLACE for these
>> filesystems, but it is not trivial, like for local filesystems.
>> RENAME_NOREPLACE must guarantee atomicity (i.e. it shouldn't be possible
>> for a file to be created on one host while it is overwritten by rename on
>> another host).
>>
>> Filesystems converted:
>>
>> 9p, afs, ceph, coda, ecryptfs, exofs, kernfs, lustre, ncpfs, nfs, ocfs2,
>> orangefs.
>>
>> After this, we can get rid of the duplicate interfaces for rename.
>>
>> Signed-off-by: Miklos Szeredi <mszeredi@...hat.com>
>> Cc: Eric Van Hensbergen <ericvh@...il.com>
>> Cc: David Howells <dhowells@...hat.com>
>> Cc: Ilya Dryomov <idryomov@...il.com>
>> Cc: Jan Harkes <jaharkes@...cmu.edu>
>> Cc: Tyler Hicks <tyhicks@...onical.com>
>> Cc: Boaz Harrosh <ooo@...ctrozaur.com>
>> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
>> Cc: Oleg Drokin <oleg.drokin@...el.com>
>> Cc: Trond Myklebust <trond.myklebust@...marydata.com>
>> Cc: Mark Fasheh <mfasheh@...e.com>
>> Cc: Mike Marshall <hubcap@...ibond.com>
>
> Acked-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>