linux-kernel - Re: [PATCH 5/5] firmware: ti_sci: Add support for reboot core service

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160823174841.GA23677@rob-hp-laptop>
Date:   Tue, 23 Aug 2016 12:48:41 -0500
From:   Rob Herring <robh@...nel.org>
To:     Nishanth Menon <nm@...com>
Cc:     Russell King <rmk+kernel@...linux.org.uk>,
        Sudeep Holla <sudeep.holla@....com>,
        Santosh Shilimkar <ssantosh@...nel.org>,
        Russ Dill <Russ.Dill@...com>, Dave Gerlach <d-gerlach@...com>,
        Lokesh Vutla <lokeshvutla@...com>,
        Peter Ujfalusi <peter.ujfalusi@...com>,
        "Andrew F . Davis" <afd@...com>, Suman Anna <s-anna@...com>,
        Tero Kristo <t-kristo@...com>, linux-kernel@...r.kernel.org,
        devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-pm@...r.kernel.org
Subject: Re: [PATCH 5/5] firmware: ti_sci: Add support for reboot core service

On Fri, Aug 19, 2016 at 05:51:59PM -0500, Nishanth Menon wrote:
> Since system controller now has control over SoC power management, it
> needs to be explicitly requested to reboot the SoC. Add support for
> it.
> 
> In some systems however, SoC needs to toggle a GPIO or send event to an
> external entity (like a PMIC) for a system reboot to take place. To
> facilitate that, we allow for a DT property to determine if the reboot
> handler will be registered and further, the service is also made
> available to other drivers (such as PMIC driver) to sequence the
> additional operation and trigger the SoC reboot as the last step.
> 
> Tested-by: Lokesh Vutla <lokeshvutla@...com>
> Signed-off-by: Nishanth Menon <nm@...com>
> ---
>  .../devicetree/bindings/arm/keystone/ti,sci.txt    |  1 +
>  drivers/firmware/ti_sci.c                          | 85 ++++++++++++++++++++++
>  drivers/firmware/ti_sci.h                          | 12 +++
>  include/linux/soc/ti/ti_sci_protocol.h             | 11 +++
>  4 files changed, 109 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/arm/keystone/ti,sci.txt b/Documentation/devicetree/bindings/arm/keystone/ti,sci.txt
> index 965d45e313b1..ed5b8fc185f1 100644
> --- a/Documentation/devicetree/bindings/arm/keystone/ti,sci.txt
> +++ b/Documentation/devicetree/bindings/arm/keystone/ti,sci.txt
> @@ -38,6 +38,7 @@ Optional Properties:
>  - reg-names:
>  	debug_messages - Map the Debug message region
>  - reg:  register space corresponding to the debug_messages
> +- ti,system-reboot-controller: If system reboot can be triggered by SoC reboot

Don't define bindings incrementally. But all the binding in one patch.

Rob