linux-kernel - Re: [PATCH 2/5] firmware: Add basic support for TI System Control Interface (TI-SCI) protocol

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 23 Aug 2016 13:38:14 -0500
From:   Nishanth Menon <nm@...com>
To:     Lokesh Vutla <lokeshvutla@...com>
Cc:     Russell King <rmk+kernel@...linux.org.uk>,
        Sudeep Holla <sudeep.holla@....com>,
        Santosh Shilimkar <ssantosh@...nel.org>,
        Russ Dill <Russ.Dill@...com>, Dave Gerlach <d-gerlach@...com>,
        Peter Ujfalusi <peter.ujfalusi@...com>,
        "Andrew F . Davis" <afd@...com>, Suman Anna <s-anna@...com>,
        Tero Kristo <t-kristo@...com>,
        lkml <linux-kernel@...r.kernel.org>,
        dt list <devicetree@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>
Subject: Re: [PATCH 2/5] firmware: Add basic support for TI System Control
 Interface (TI-SCI) protocol

On Sun, Aug 21, 2016 at 11:20 AM, Lokesh Vutla <lokeshvutla@...com> wrote:
[...]

>> +
>> +static int ti_sci_remove(struct platform_device *pdev)
>> +{
>> +     struct ti_sci_info *info;
>> +     int ret = 0;
>> +
>> +     info = platform_get_drvdata(pdev);
>> +
>> +     mutex_lock(&ti_sci_list_mutex);
>> +     if (info->users)
>> +             ret = -EBUSY;
>> +     else
>> +             list_del(&info->node);
>> +     mutex_unlock(&ti_sci_list_mutex);
>
> shouldn't the mbox channels be freed in remove?
>
> mbox_free_channel(info->chan_tx);
> mbox_free_channel(info->chan_rx);

Uggh.. yes.. my bad. thanks for catching this. will fix with a v2 next
week if there are no further comments.

--
Regards,
NIshanth Menon