linux-kernel - Re: [PATCH] infiniband/mlx5: Remove superfluous include of io-mapping.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160823211550.GQ15065@leon.nu>
Date:   Wed, 24 Aug 2016 00:15:50 +0300
From:   Leon Romanovsky <leonro@...lanox.com>
To:     Chris Wilson <chris@...is-wilson.co.uk>
Cc:     linux-rdma@...r.kernel.org, linux-kernel@...r.kernel.org,
        Eli Cohen <eli@...lanox.com>,
        Jack Morgenstein <jackm@....mellanox.co.il>,
        Or Gerlitz <ogerlitz@...lanox.com>,
        Matan Barak <matanb@...lanox.com>,
        Doug Ledford <dledford@...hat.com>,
        Sean Hefty <sean.hefty@...el.com>,
        Hal Rosenstock <hal.rosenstock@...il.com>
Subject: Re: [PATCH] infiniband/mlx5: Remove superfluous include of
 io-mapping.h

On Tue, Aug 23, 2016 at 09:16:26PM +0100, Chris Wilson wrote:
> This file does not use any structs or functions defined by io-mapping.h
> (nor does it directly use iomap, ioremap, iounamp or friends). Remove it
> to simplify verification of changes to io-mapping.h
> 
> The include existed since its inception in
> 
> commit e126ba97dba9edeb6fafa3665b5f8497fc9cdf8c
> Author: Eli Cohen <eli@...lanox.com>
> Date:   Sun Jul 7 17:25:49 2013 +0300
> 
>     mlx5: Add driver for Mellanox Connect-IB adapters
> 
> which looks like a copy across from the Mellanox ethernet driver.
> 
> Signed-off-by: Chris Wilson <chris@...is-wilson.co.uk>

I assume that it passed 0-day builds.

Except the commit message, which doesn't follow SubmittingPatches guide,
it looks good.

Reviewed-by: Leon Romanovsky <leonro@...lanox.com>

Thanks

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)