linux-kernel - Re: [PATCH] infiniband/mlx5: Remove superfluous include of io-mapping.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160823212424.GA9014@nuc-i3427.alporthouse.com>
Date:   Tue, 23 Aug 2016 22:24:24 +0100
From:   Chris Wilson <chris@...is-wilson.co.uk>
To:     Leon Romanovsky <leonro@...lanox.com>
Cc:     linux-rdma@...r.kernel.org, linux-kernel@...r.kernel.org,
        Eli Cohen <eli@...lanox.com>,
        Jack Morgenstein <jackm@....mellanox.co.il>,
        Or Gerlitz <ogerlitz@...lanox.com>,
        Matan Barak <matanb@...lanox.com>,
        Doug Ledford <dledford@...hat.com>,
        Sean Hefty <sean.hefty@...el.com>,
        Hal Rosenstock <hal.rosenstock@...il.com>
Subject: Re: [PATCH] infiniband/mlx5: Remove superfluous include of
 io-mapping.h

On Wed, Aug 24, 2016 at 12:15:50AM +0300, Leon Romanovsky wrote:
> On Tue, Aug 23, 2016 at 09:16:26PM +0100, Chris Wilson wrote:
> > This file does not use any structs or functions defined by io-mapping.h
> > (nor does it directly use iomap, ioremap, iounamp or friends). Remove it
> > to simplify verification of changes to io-mapping.h
> > 
> > The include existed since its inception in
> > 
> > commit e126ba97dba9edeb6fafa3665b5f8497fc9cdf8c
> > Author: Eli Cohen <eli@...lanox.com>
> > Date:   Sun Jul 7 17:25:49 2013 +0300
> > 
> >     mlx5: Add driver for Mellanox Connect-IB adapters
> > 
> > which looks like a copy across from the Mellanox ethernet driver.
> > 
> > Signed-off-by: Chris Wilson <chris@...is-wilson.co.uk>
> 
> I assume that it passed 0-day builds.
> 
> Except the commit message, which doesn't follow SubmittingPatches guide,
> it looks good.

If you mean the full commit reference rather than the short form, the
long form can be preferred if it lends significance. In this case I
wanted to highlight that it was the original commit that introduced the
include.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre