linux-kernel - Re: [PATCH] infiniband/mlx5: Remove superfluous include of io-mapping.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1070024890.2212210.1472009705267.JavaMail.zimbra@redhat.com>
Date:   Tue, 23 Aug 2016 23:35:05 -0400 (EDT)
From:   Laurence Oberman <loberman@...hat.com>
To:     Chris Wilson <chris@...is-wilson.co.uk>
Cc:     linux-rdma@...r.kernel.org, linux-kernel@...r.kernel.org,
        Eli Cohen <eli@...lanox.com>,
        Jack Morgenstein <jackm@....mellanox.co.il>,
        Or Gerlitz <ogerlitz@...lanox.com>,
        Matan Barak <matanb@...lanox.com>,
        Leon Romanovsky <leonro@...lanox.com>,
        Doug Ledford <dledford@...hat.com>,
        Sean Hefty <sean.hefty@...el.com>,
        Hal Rosenstock <hal.rosenstock@...il.com>
Subject: Re: [PATCH] infiniband/mlx5: Remove superfluous include of
 io-mapping.h



----- Original Message -----
> From: "Chris Wilson" <chris@...is-wilson.co.uk>
> To: linux-rdma@...r.kernel.org
> Cc: linux-kernel@...r.kernel.org, "Chris Wilson" <chris@...is-wilson.co.uk>, "Eli Cohen" <eli@...lanox.com>, "Jack
> Morgenstein" <jackm@....mellanox.co.il>, "Or Gerlitz" <ogerlitz@...lanox.com>, "Matan Barak" <matanb@...lanox.com>,
> "Leon Romanovsky" <leonro@...lanox.com>, "Doug Ledford" <dledford@...hat.com>, "Sean Hefty" <sean.hefty@...el.com>,
> "Hal Rosenstock" <hal.rosenstock@...il.com>
> Sent: Tuesday, August 23, 2016 4:16:26 PM
> Subject: [PATCH] infiniband/mlx5: Remove superfluous include of io-mapping.h
> 
> This file does not use any structs or functions defined by io-mapping.h
> (nor does it directly use iomap, ioremap, iounamp or friends). Remove it
> to simplify verification of changes to io-mapping.h
> 
> The include existed since its inception in
> 
> commit e126ba97dba9edeb6fafa3665b5f8497fc9cdf8c
> Author: Eli Cohen <eli@...lanox.com>
> Date:   Sun Jul 7 17:25:49 2013 +0300
> 
>     mlx5: Add driver for Mellanox Connect-IB adapters
> 
> which looks like a copy across from the Mellanox ethernet driver.
> 
> Signed-off-by: Chris Wilson <chris@...is-wilson.co.uk>
> Cc: Eli Cohen <eli@...lanox.com>
> Cc: Jack Morgenstein <jackm@....mellanox.co.il>
> Cc: Or Gerlitz <ogerlitz@...lanox.com>
> Cc: Matan Barak <matanb@...lanox.com>
> Cc: Leon Romanovsky <leonro@...lanox.com>
> Cc: Doug Ledford <dledford@...hat.com>
> Cc: Sean Hefty <sean.hefty@...el.com>
> Cc: Hal Rosenstock <hal.rosenstock@...il.com>
> Cc: linux-rdma@...r.kernel.org
> ---
>  drivers/infiniband/hw/mlx5/main.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/infiniband/hw/mlx5/main.c
> b/drivers/infiniband/hw/mlx5/main.c
> index a84bb766fc62..1b4094baa2de 100644
> --- a/drivers/infiniband/hw/mlx5/main.c
> +++ b/drivers/infiniband/hw/mlx5/main.c
> @@ -37,7 +37,6 @@
>  #include <linux/pci.h>
>  #include <linux/dma-mapping.h>
>  #include <linux/slab.h>
> -#include <linux/io-mapping.h>
>  #if defined(CONFIG_X86)
>  #include <asm/pat.h>
>  #endif
> --
> 2.9.3
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
I compiled and tested this with no issues on my mlx5 test bed.

Reviewed-by Laurence Oberman <loberman@...hat.com>
Tested-by Laurence Oberman <loberman@...hat.com>