linux-kernel - Re: [PATCH 0/3] acpi, nfit: nvdimm notification support + tests

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160823223957.GC7799@omniknight.lm.intel.com>
Date:   Tue, 23 Aug 2016 16:39:57 -0600
From:   Vishal Verma <vishal.l.verma@...el.com>
To:     Dan Williams <dan.j.williams@...el.com>
Cc:     linux-nvdimm@...ts.01.org,
        "Rafael J. Wysocki" <rafael.j.wysocki@...el.com>,
        linux-kernel@...r.kernel.org, Toshi Kani <toshi.kani@....com>,
        linux-acpi@...r.kernel.org
Subject: Re: [PATCH 0/3] acpi, nfit: nvdimm notification support + tests

On 08/23, Dan Williams wrote:
> ACPI 6.1 added an "NFIT Health Event Notification" for nvdimm devices.
> When this fires, system software is expected to issue a DSM to retrieve
> the latest health values.  For the NFIT driver this notification
> arrives as an event on the sysfs 'flags' attribute for an nfit/nvdimm
> device.  The 'flags' attribute reflects the "NVDIMM State Flags" of the
> "5.2.25.3 NVDIMM Region Mapping Structure", and when read indicates if
> the platform supports sending health events.
> 
> ---
> 
> Dan Williams (3):
>       tools/testing/nvdimm: unit test for acpi_nfit_notify()
>       acpi, nfit: add dimm device notification support
>       tools/testing/nvdimm: unit test for acpi_nvdimm_notify()
> 
> 
>  drivers/acpi/nfit/core.c          |  112 ++++++++++++++++++++++++++++++++-----
>  drivers/acpi/nfit/nfit.h          |    7 ++
>  drivers/nvdimm/dimm_devs.c        |    6 ++
>  include/linux/libnvdimm.h         |    1 
>  tools/testing/nvdimm/Kbuild       |    1 
>  tools/testing/nvdimm/test/iomap.c |   17 ++++++
>  tools/testing/nvdimm/test/nfit.c  |   64 +++++++++++++++++++--
>  7 files changed, 188 insertions(+), 20 deletions(-)

Looks good to me. For the series,

Reviewed-by: Vishal Verma <vishal.l.verma@...el.com>