linux-kernel - Re: [PATCH v10 3/8] i2c: thunderx: Add i2c driver for ThunderX SOC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160823210934.GA28936@hardcore>
Date:   Tue, 23 Aug 2016 23:09:34 +0200
From:   Jan Glauber <jan.glauber@...iumnetworks.com>
To:     Wolfram Sang <wsa@...-dreams.de>
CC:     <linux-kernel@...r.kernel.org>, <linux-i2c@...r.kernel.org>,
        David Daney <ddaney@...iumnetworks.com>,
        <Steven.Hill@...iumnetworks.com>
Subject: Re: [PATCH v10 3/8] i2c: thunderx: Add i2c driver for ThunderX SOC

On Tue, Aug 23, 2016 at 10:39:41PM +0200, Wolfram Sang wrote:
> On Tue, Aug 23, 2016 at 10:36:29PM +0200, Wolfram Sang wrote:
> > 
> > >  i2c-octeon-objs := i2c-cavium.o i2c-octeon-core.o
> > >  obj-$(CONFIG_I2C_OCTEON)	+= i2c-octeon.o
> > > +i2c-thunderx-objs := i2c-cavium.o i2c-thunderx-core.o
> > > +obj-$(CONFIG_I2C_THUNDERX)	+= i2c-thunderx.o
> > 
> > Shouldn't that rather be "i2c-cavium-core.o",
> 
> Thinking of it again, it should probably even be "i2c-octeon-core.o" to
> avoid confusion because all the functions start with octeon_*
> 
> > "i2c-octeon-platdrv.o",  and "i2c-thunderx-pcidrv.o" for the -objs?
> 
> Those names still make sense :)
> 

Agreed, the naming you propose looks much better.

--Jan