linux-kernel - Re: [PATCH 2/2] sdhci-of-arasan: Add quirk and device tree parameter to fake CD bit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <935c7618-a403-775b-b45c-c3b97e0ed252@metafoo.de>
Date:   Thu, 25 Aug 2016 12:37:46 +0200
From:   Lars-Peter Clausen <lars@...afoo.de>
To:     Zach Brown <zach.brown@...com>, adrian.hunter@...el.com
Cc:     robh+dt@...nel.org, ulf.hansson@...aro.org, mark.rutland@....com,
        linux-mmc@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, michal.simek@...inx.com,
        soren.brinkmann@...inx.com, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH 2/2] sdhci-of-arasan: Add quirk and device tree parameter
 to fake CD bit

On 08/25/2016 01:23 AM, Zach Brown wrote:
> The sdhci controller on xilinx zynq devices will not function unless
> the cd bit is provided. http://www.xilinx.com/support/answers/61064.html
> In cases where it is impossible to provide the cd bit in hardware,
> setting the controller to test mode and then setting inserted to true
> will get the controller to function with out the cd bit.
> 
> The device property "fake-cd" will let the arasan driver know it needs
> to fake the cd bit for the controller inorder for the controller to
> function with a SD card that does not provide the CD bit.

The devicetree is supposed to be descriptive rather than imperative. fake-cd
is a bit more on the later side. There is already a standard property for
describing that the card-detect pin is not connected, called 'broken-cd'.
Can that be used instead?