linux-kernel - Re: [PATCH 2/5] Drivers: hv: balloon: account for gaps in hot add regions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87d1kxavxl.fsf@vitty.brq.redhat.com>
Date:   Thu, 25 Aug 2016 14:13:10 +0200
From:   Vitaly Kuznetsov <vkuznets@...hat.com>
To:     Yauheni Kaliuta <yauheni.kaliuta@...hat.com>
Cc:     kys@...hange.microsoft.com, gregkh@...uxfoundation.org,
        linux-kernel@...r.kernel.org, devel@...uxdriverproject.org,
        olaf@...fle.de, apw@...onical.com, jasowang@...hat.com,
        leann.ogasawara@...onical.com, alexng@...rosoft.com
Subject: Re: [PATCH 2/5] Drivers: hv: balloon: account for gaps in hot add regions

Yauheni Kaliuta <yauheni.kaliuta@...hat.com> writes:

> Hi, kys!
>
>>>>>> On Wed, 24 Aug 2016 16:23:10 -0700, kys   wrote:
>
> [...]
>
>  > -static bool pfn_covered(unsigned long start_pfn, unsigned long pfn_cnt)
>  > +static int pfn_covered(unsigned long start_pfn, unsigned long pfn_cnt)
>  >  {
>  >  	struct list_head *cur;
>  >  	struct hv_hotadd_state *has;
>  > +	struct hv_hotadd_gap *gap;
>  >  	unsigned long residual, new_inc;
>
>  >  	if (list_empty(&dm_device.ha_region_list))
>
> One "return false;" left here.
>

This is removed in patch 4/5 of this series and false is 0 anyway)

[...]

-- 
  Vitaly