linux-kernel - RE: [PATCH 2/5] Drivers: hv: balloon: account for gaps in hot add regions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 25 Aug 2016 17:00:19 +0000
From:   KY Srinivasan <kys@...rosoft.com>
To:     Yauheni Kaliuta <yauheni.kaliuta@...hat.com>,
        "kys@...hange.microsoft.com" <kys@...hange.microsoft.com>
CC:     "olaf@...fle.de" <olaf@...fle.de>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        "jasowang@...hat.com" <jasowang@...hat.com>,
        "Alex Ng (LIS)" <alexng@...rosoft.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "apw@...onical.com" <apw@...onical.com>,
        "devel@...uxdriverproject.org" <devel@...uxdriverproject.org>,
        "leann.ogasawara@...onical.com" <leann.ogasawara@...onical.com>
Subject: RE: [PATCH 2/5] Drivers: hv: balloon: account for gaps in hot add
 regions



> -----Original Message-----
> From: devel [mailto:driverdev-devel-bounces@...uxdriverproject.org] On
> Behalf Of Yauheni Kaliuta
> Sent: Wednesday, August 24, 2016 9:54 PM
> To: kys@...hange.microsoft.com
> Cc: olaf@...fle.de; gregkh@...uxfoundation.org; jasowang@...hat.com; Alex
> Ng (LIS) <alexng@...rosoft.com>; linux-kernel@...r.kernel.org;
> apw@...onical.com; devel@...uxdriverproject.org;
> leann.ogasawara@...onical.com
> Subject: Re: [PATCH 2/5] Drivers: hv: balloon: account for gaps in hot add
> regions
> 
> Hi, kys!
> 
> >>>>> On Wed, 24 Aug 2016 16:23:10 -0700, kys   wrote:
> 
> [...]
> 
>  > -static bool pfn_covered(unsigned long start_pfn, unsigned long pfn_cnt)
>  > +static int pfn_covered(unsigned long start_pfn, unsigned long pfn_cnt)
>  >  {
>  >  	struct list_head *cur;
>  >  	struct hv_hotadd_state *has;
>  > +	struct hv_hotadd_gap *gap;
>  >  	unsigned long residual, new_inc;
> 
>  >  	if (list_empty(&dm_device.ha_region_list))
> 
> One "return false;" left here.

It is fixed up later in the series and the series is bisectable.

K. Y