linux-kernel - Re: [PATCH v3] clk: let clk_disable() return immediately if clk is NULL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <194aebe5-38dd-f43d-fb4d-16ce592a68e8@gmail.com>
Date:   Thu, 25 Aug 2016 08:27:07 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Masahiro Yamada <yamada.masahiro@...ionext.com>,
        linux-clk@...r.kernel.org
Cc:     Stephen Boyd <sboyd@...eaurora.org>,
        Ralf Baechle <ralf@...ux-mips.org>,
        Michael Turquette <mturquette@...libre.com>,
        linux-mips@...ux-mips.org,
        Haojian Zhuang <haojian.zhuang@...il.com>,
        Eric Miao <eric.y.miao@...il.com>,
        linux-kernel@...r.kernel.org,
        adi-buildroot-devel@...ts.sourceforge.net,
        Greg Ungerer <gerg@...ux-m68k.org>,
        linux-m68k@...ts.linux-m68k.org,
        bcm-kernel-feedback-list@...adcom.com,
        Wan ZongShun <mcuos.com@...il.com>,
        Geert Uytterhoeven <geert@...ux-m68k.org>,
        Steven Miao <realmz6@...il.com>,
        Russell King <linux@...linux.org.uk>,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v3] clk: let clk_disable() return immediately if clk is
 NULL

On 08/24/2016 10:26 AM, Masahiro Yamada wrote:
> Many of clk_disable() implementations just return for NULL pointer,
> but this check is missing from some.  Let's make it tree-wide
> consistent.  It will allow clock consumers to call clk_disable()
> without NULL pointer check.
> 
> Signed-off-by: Masahiro Yamada <yamada.masahiro@...ionext.com>
> Acked-by: Greg Ungerer <gerg@...inux.org>
> Acked-by: Wan Zongshun <mcuos.com@...il.com>
> ---
> 
> I came back after a long pause.
> You can see the discussion about the previous version:
> https://www.linux-mips.org/archives/linux-mips/2016-04/msg00063.html
> 
> 
> Changes in v3:
>   - Return only when clk is NULL.  Do not take care of error pointer.
> 
> Changes in v2:
>   - Rebase on Linux 4.6-rc1
> 
>  arch/arm/mach-mmp/clock.c        | 3 +++
>  arch/arm/mach-w90x900/clock.c    | 3 +++
>  arch/blackfin/mach-bf609/clock.c | 3 +++
>  arch/m68k/coldfire/clk.c         | 4 ++++
>  arch/mips/bcm63xx/clk.c          | 3 +++

For bcm63xx:

Acked-by: Florian Fainelli <f.fainelli@...il.com>
-- 
Florian