linux-kernel - Re: [RESEND PATCH] staging: octeon: Use IS_ENABLED() instead of checking for built-in or module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 25 Aug 2016 09:01:08 -0700
From:   David Daney <ddaney@...iumnetworks.com>
To:     Javier Martinez Canillas <javier@....samsung.com>
CC:     <linux-kernel@...r.kernel.org>, <devel@...verdev.osuosl.org>,
        Aaro Koskinen <aaro.koskinen@...ia.com>,
        David Daney <david.daney@...ium.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Cristina Moraru <cristina.moraru09@...il.com>,
        Laura Garcia Liebana <nevola@...il.com>,
        Bhaktipriya Shridhar <bhaktipriya96@...il.com>,
        Philippe Reynes <tremyfr@...il.com>
Subject: Re: [RESEND PATCH] staging: octeon: Use IS_ENABLED() instead of checking
 for built-in or module

On 08/25/2016 06:55 AM, Javier Martinez Canillas wrote:
> The IS_ENABLED() macro checks if a Kconfig symbol has been enabled either
> built-in or as a module, use that macro instead of open coding the same.
>
> Using the macro makes the code more readable by helping abstract away some
> of the Kconfig built-in and module enable details.
>
> Signed-off-by: Javier Martinez Canillas <javier@....samsung.com>
> Acked-by: David Daney <david.daney@...ium.com>
>
> ---
>
> Changes since first post:
> - Added David Daney Acked-by tag.
> - Rebased on top of latest master.
>

You changed something about the patch.  In this case the Subject is not 
"RESEND", but rather "v2".  Incorrect Subject lines like this can lead 
to the patch being inadvertently ignored.

David Daney

>   drivers/staging/octeon/ethernet.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/octeon/ethernet.c b/drivers/staging/octeon/ethernet.c
> index 2eb97317f631..a473f034b01a 100644
> --- a/drivers/staging/octeon/ethernet.c
> +++ b/drivers/staging/octeon/ethernet.c
> @@ -237,7 +237,7 @@ static int cvm_oct_common_change_mtu(struct net_device *dev, int new_mtu)
>   {
>   	struct octeon_ethernet *priv = netdev_priv(dev);
>   	int interface = INTERFACE(priv->port);
> -#if defined(CONFIG_VLAN_8021Q) || defined(CONFIG_VLAN_8021Q_MODULE)
> +#if IS_ENABLED(CONFIG_VLAN_8021Q)
>   	int vlan_bytes = 4;
>   #else
>   	int vlan_bytes = 0;
>