linux-kernel - Re: [RESEND PATCH] staging: octeon: Use IS_ENABLED() instead of checking for built-in or module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ff2cfb41-50e0-4904-d685-0266c62ae4ab@osg.samsung.com>
Date:   Thu, 25 Aug 2016 18:56:07 -0400
From:   Javier Martinez Canillas <javier@....samsung.com>
To:     David Daney <ddaney@...iumnetworks.com>
Cc:     linux-kernel@...r.kernel.org, devel@...verdev.osuosl.org,
        Aaro Koskinen <aaro.koskinen@...ia.com>,
        David Daney <david.daney@...ium.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Cristina Moraru <cristina.moraru09@...il.com>,
        Laura Garcia Liebana <nevola@...il.com>,
        Bhaktipriya Shridhar <bhaktipriya96@...il.com>,
        Philippe Reynes <tremyfr@...il.com>
Subject: Re: [RESEND PATCH] staging: octeon: Use IS_ENABLED() instead of
 checking for built-in or module

Hello David,

On 08/25/2016 12:01 PM, David Daney wrote:
> On 08/25/2016 06:55 AM, Javier Martinez Canillas wrote:
>> The IS_ENABLED() macro checks if a Kconfig symbol has been enabled either
>> built-in or as a module, use that macro instead of open coding the same.
>>
>> Using the macro makes the code more readable by helping abstract away some
>> of the Kconfig built-in and module enable details.
>>
>> Signed-off-by: Javier Martinez Canillas <javier@....samsung.com>
>> Acked-by: David Daney <david.daney@...ium.com>
>>
>> ---
>>
>> Changes since first post:
>> - Added David Daney Acked-by tag.
>> - Rebased on top of latest master.
>>
> 
> You changed something about the patch.  In this case the Subject is not "RESEND", but rather "v2".  Incorrect Subject lines like this can lead to the patch being inadvertently ignored.
>

Yes, in fact I thought about adding a v2 suffix instead of RESEND but since
I didn't change the patch content (besides merge conflicts resolution), I
preferred to add the latter.

I can re-spin the patch if that's an issue.

> David Daney
> 
 
Best regards,
-- 
Javier Martinez Canillas
Open Source Group
Samsung Research America