linux-kernel - Re: [PATCH] fix:memory:omap-gpmc:mark symbols static where possible

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a07bfba4-0e75-4797-85f9-67c279b374f4@ti.com>
Date:   Mon, 29 Aug 2016 10:32:44 +0300
From:   Roger Quadros <rogerq@...com>
To:     Baoyou Xie <baoyou.xie@...aro.org>, <tony@...mide.com>
CC:     <linux-omap@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <arnd@...aro.org>, <xie.baoyou@....com.cn>
Subject: Re: [PATCH] fix:memory:omap-gpmc:mark symbols static where possible

Hi,

On 28/08/16 08:28, Baoyou Xie wrote:
> We get 1 warning when build kernel with W=1:
> drivers/memory/omap-gpmc.c:354:14: warning: no previous prototype for 'gpmc_clk_ticks_to_ns' [-Wmissing-prototypes]
> 
> In fact, this function is only used in the file in which it is declared
> and don't need a declaration, but can be made static.
> so this patch marks it 'static'.
> 
> Signed-off-by: Baoyou Xie <baoyou.xie@...aro.org>
> ---
>  drivers/memory/omap-gpmc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/memory/omap-gpmc.c b/drivers/memory/omap-gpmc.c
> index 869c83f..f71cbf7 100644
> --- a/drivers/memory/omap-gpmc.c
> +++ b/drivers/memory/omap-gpmc.c
> @@ -350,7 +350,7 @@ static unsigned int gpmc_ps_to_ticks(unsigned int time_ps)
>  	return (time_ps + tick_ps - 1) / tick_ps;
>  }
>  
> -unsigned int gpmc_clk_ticks_to_ns(unsigned ticks, int cs,
> +static unsigned int gpmc_clk_ticks_to_ns(unsigned int ticks, int cs,
>  				  enum gpmc_clk_domain cd)
>  {
>  	return ticks * gpmc_get_clk_period(cs, cd) / 1000;
> 

This patch fails checkpatch with following error

CHECK: Alignment should match open parenthesis
#28: FILE: drivers/memory/omap-gpmc.c:354:
+static unsigned int gpmc_clk_ticks_to_ns(unsigned int ticks, int cs,
 				  enum gpmc_clk_domain cd)

Also IMO patch subject is better as
"memory: omap-gpmc: make gpmc_clk_ticks_to_ns() static"

I'll fix these issues myself this time. Thanks for the fix.
Picked for v4.9.

regards,
-roger