linux-kernel - Re: [PATCH v1 4/5] ARM: dts: ls1043a: add qDMA node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3583547.0zriK9IoAs@ws-stein>
Date:   Mon, 29 Aug 2016 09:34:16 +0200
From:   Alexander Stein <alexander.stein@...tec-electronic.com>
To:     linux-kernel@...r.kernel.org
Cc:     Yuan Yao <yao.yuan@...escale.com>, vinod.koul@...el.com,
        robh+dt@...nel.org, dan.j.williams@...el.com, mark.rutland@....com,
        linux@...linux.org.uk, shawnguo@...nel.org, leoyang.li@....com,
        dmaengine@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        Yuan Yao <yao.yuan@....com>
Subject: Re: [PATCH v1 4/5] ARM: dts: ls1043a: add qDMA node

On Thursday 18 August 2016 14:38:47, Yuan Yao wrote:
> From: Yuan Yao <yao.yuan@....com>
> 
> Add the QDMA node for ls1043a platform to
> support QDMA driver.
> 
> Signed-off-by: Yuan Yao <yao.yuan@....com>
> ---
>  arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi
> b/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi index e8e4c3e..e463074
> 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi
> @@ -467,6 +467,16 @@
>  				 <&clockgen 4 0>;
>  		};
> 
> +		qdma: qdma@...0000 {
> +			compatible = "fsl,ls1021a-qdma", "fsl,ls1043a-qdma";

This doesn't match the order of your binding in Patch 2/5:
> +- compatible :
> +       - "fsl,ls1021a-qdma",
> +       Or "fsl,ls1043a-qdma" followed by "fsl,ls1021a-qdma",

It should be the other way around.

Best regards,
Alexander