linux-kernel - Re: [PATCH v2] fix:brcmfmac: add missing header dependencies

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6e8b16f5-b4c7-39eb-dad4-d7fb3c08667f@broadcom.com>
Date:   Mon, 29 Aug 2016 09:59:46 +0200
From:   Arend Van Spriel <arend.vanspriel@...adcom.com>
To:     Baoyou Xie <baoyou.xie@...aro.org>, franky.lin@...adcom.com,
        hante.meuleman@...adcom.com, kvalo@...eaurora.org
Cc:     linux-wireless@...r.kernel.org,
        brcm80211-dev-list.pdl@...adcom.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, arnd@...aro.org,
        xie.baoyou@....com.cn
Subject: Re: [PATCH v2] fix:brcmfmac: add missing header dependencies

On 27-8-2016 8:08, Baoyou Xie wrote:
> We get 1 warning when biuld kernel with W=1:
> drivers/net/wireless/broadcom/brcm80211/brcmfmac/tracepoint.c:23:6: warning: no previous prototype for '__brcmf_err' [-Wmissing-
> prototypes]
> 
> In fact, this function is declared in brcmfmac/debug.h, so this patch
> add missing header dependencies

Thanks for this fix, but please remove the 'fix:' prefix in the subject
as it just noise.

Regards,
Arend

> Signed-off-by: Baoyou Xie <baoyou.xie@...aro.org>
> ---
>  drivers/net/wireless/broadcom/brcm80211/brcmfmac/tracepoint.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/tracepoint.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/tracepoint.c
> index a10f35c..fe67559 100644
> --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/tracepoint.c
> +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/tracepoint.c
> @@ -19,6 +19,7 @@
>  #ifndef __CHECKER__
>  #define CREATE_TRACE_POINTS
>  #include "tracepoint.h"
> +#include "debug.h"
>  
>  void __brcmf_err(const char *func, const char *fmt, ...)
>  {
>