linux-kernel - Re: [PATCH] mtd: nand: davinci: Reinitialize the HW ECC engine in 4bit hwctl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160829115930.517a133e@bbrezillon>
Date:   Mon, 29 Aug 2016 11:59:30 +0200
From:   Boris Brezillon <boris.brezillon@...e-electrons.com>
To:     Karl Beldan <kbeldan@...libre.com>,
        Brian Norris <computersforpeace@...il.com>
Cc:     linux-mtd@...ts.infradead.org, linux-kernel@...r.kernel.org,
        Richard Weinberger <richard@....at>,
        David Woodhouse <dwmw2@...radead.org>,
        Sekhar Nori <nsekhar@...com>,
        Kevin Hilman <khilman@...libre.com>,
        Karl Beldan <karl.beldan+oss@...il.com>
Subject: Re: [PATCH] mtd: nand: davinci: Reinitialize the HW ECC engine in
 4bit hwctl

On Mon, 29 Aug 2016 07:45:49 +0000
Karl Beldan <kbeldan@...libre.com> wrote:

> This fixes subpage writes when using 4-bit HW ECC.
> 
> There has been numerous reports about ECC errors with devices using this
> driver for a while.  Also the 4-bit ECC has been reported as broken with
> subpages in [1] and with 16 bits NANDs in the driver and in mach* board
> files both in mainline and in the vendor BSPs.
> 
> What I saw with 4-bit ECC on a 16bits NAND (on an LCDK) which got me to
> try reinitializing the ECC engine:
> - R/W on whole pages properly generates/checks RS code
> - try writing the 1st subpage only of a blank page, the subpage is well
>   written and the RS code properly generated, re-reading the same page
>   the HW detects some ECC error, reading the same page again no ECC
>   error is detected
> 
> Note that the ECC engine is already reinitialized in the 1-bit case.
> 
> Tested on my LCDK with UBI+UBIFS using subpages.
> This could potentially get rid of the issue workarounded in [1].
> 
> [1] 28c015a9daab ("mtd: davinci-nand: disable subpage write for keystone-nand")
> 
> Signed-off-by: Karl Beldan <kbeldan@...libre.com>

Acked-by: Boris Brezillon <boris.brezillon@...e-electrons.com>

Brian, can you take this patch directly in your tree. If that's not
possible, let me know, I'll add the Fixes and Cc:stable tags and take
it for 4.9.

Thanks,

Boris

> ---
>  drivers/mtd/nand/davinci_nand.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/mtd/nand/davinci_nand.c b/drivers/mtd/nand/davinci_nand.c
> index cc07ba0..27fa8b8 100644
> --- a/drivers/mtd/nand/davinci_nand.c
> +++ b/drivers/mtd/nand/davinci_nand.c
> @@ -240,6 +240,9 @@ static void nand_davinci_hwctl_4bit(struct mtd_info *mtd, int mode)
>  	unsigned long flags;
>  	u32 val;
>  
> +	/* Reset ECC hardware */
> +	davinci_nand_readl(info, NAND_4BIT_ECC1_OFFSET);
> +
>  	spin_lock_irqsave(&davinci_nand_lock, flags);
>  
>  	/* Start 4-bit ECC calculation for read/write */