linux-kernel - Re: [PATCH] nfsd: constify reply_cache_stats

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1472468267.2597.0.camel@poochiereds.net>
Date:   Mon, 29 Aug 2016 06:57:47 -0400
From:   Jeff Layton <jlayton@...chiereds.net>
To:     Julia Lawall <Julia.Lawall@...6.fr>,
        "J. Bruce Fields" <bfields@...ldses.org>
Cc:     kernel-janitors@...r.kernel.org, linux-nfs@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] nfsd: constify reply_cache_stats_operations structure

On Sun, 2016-08-28 at 22:36 +0200, Julia Lawall wrote:
> reply_cache_stats_operations, of type struct file_operations, is
> never
> modified, so declare it as const.
> 
> Done with the help of Coccinelle.
> 
> Signed-off-by: Julia Lawall <Julia.Lawall@...6.fr>
> 
> ---
>  fs/nfsd/nfsctl.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/nfsd/nfsctl.c b/fs/nfsd/nfsctl.c
> index 65ad016..3bc9693 100644
> --- a/fs/nfsd/nfsctl.c
> +++ b/fs/nfsd/nfsctl.c
> @@ -217,7 +217,7 @@ static const struct file_operations
> pool_stats_operations = {
>  	.release	= nfsd_pool_stats_release,
>  };
>  
> -static struct file_operations reply_cache_stats_operations = {
> +static const struct file_operations reply_cache_stats_operations = {
>  	.open		= nfsd_reply_cache_stats_open,
>  	.read		= seq_read,
>  	.llseek		= seq_lseek,
> 

I'm pretty sure Bruce will pick this up for v4.9:

Reviewed-by: Jeff Layton <jlayton@...chiereds.net>