linux-kernel - Re: [PATCH] nfsd: constify reply_cache_stats

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20161108203612.GD26589@fieldses.org>
Date:   Tue, 8 Nov 2016 15:36:12 -0500
From:   "J. Bruce Fields" <bfields@...ldses.org>
To:     Jeff Layton <jlayton@...chiereds.net>
Cc:     Julia Lawall <Julia.Lawall@...6.fr>,
        kernel-janitors@...r.kernel.org, linux-nfs@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] nfsd: constify reply_cache_stats_operations structure

On Mon, Aug 29, 2016 at 06:57:47AM -0400, Jeff Layton wrote:
> On Sun, 2016-08-28 at 22:36 +0200, Julia Lawall wrote:
> > reply_cache_stats_operations, of type struct file_operations, is
> > never
> > modified, so declare it as const.
> > 
> > Done with the help of Coccinelle.
> > 
> > Signed-off-by: Julia Lawall <Julia.Lawall@...6.fr>
> > 
> > ---
> >  fs/nfsd/nfsctl.c |    2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/fs/nfsd/nfsctl.c b/fs/nfsd/nfsctl.c
> > index 65ad016..3bc9693 100644
> > --- a/fs/nfsd/nfsctl.c
> > +++ b/fs/nfsd/nfsctl.c
> > @@ -217,7 +217,7 @@ static const struct file_operations
> > pool_stats_operations = {
> >  	.release	= nfsd_pool_stats_release,
> >  };
> >  
> > -static struct file_operations reply_cache_stats_operations = {
> > +static const struct file_operations reply_cache_stats_operations = {
> >  	.open		= nfsd_reply_cache_stats_open,
> >  	.read		= seq_read,
> >  	.llseek		= seq_lseek,
> > 
> 
> I'm pretty sure Bruce will pick this up for v4.9:

Except, for some reason it's been languishing in my inbox.  Apologies,
applying....

--b.

> 
> Reviewed-by: Jeff Layton <jlayton@...chiereds.net>