linux-kernel - Re: [PATCHv3 3/6] x86/arch_prctl/vdso: add ARCH_MAP_VDSO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 29 Aug 2016 14:12:19 +0300
From:   Dmitry Safonov <dsafonov@...tuozzo.com>
To:     kbuild test robot <lkp@...el.com>
CC:     <kbuild-all@...org>, <linux-kernel@...r.kernel.org>,
        <0x7f454c46@...il.com>, <luto@...nel.org>, <oleg@...hat.com>,
        <tglx@...utronix.de>, <hpa@...or.com>, <mingo@...hat.com>,
        <linux-mm@...ck.org>, <x86@...nel.org>, <gorcunov@...nvz.org>,
        <xemul@...tuozzo.com>
Subject: Re: [PATCHv3 3/6] x86/arch_prctl/vdso: add ARCH_MAP_VDSO_*

On 08/27/2016 09:09 PM, kbuild test robot wrote:
> Hi Dmitry,
>
> [auto build test ERROR on v4.8-rc3]
> [also build test ERROR on next-20160825]
> [cannot apply to tip/x86/core tip/x86/vdso linux/master]
> [if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
> [Suggest to use git(>=2.9.0) format-patch --base=<commit> (or --base=auto for convenience) to record what (public, well-known) commit your patch series was built on]
> [Check https://git-scm.com/docs/git-format-patch for more information]
>
> url:    https://github.com/0day-ci/linux/commits/Dmitry-Safonov/x86-32-bit-compatible-C-R-on-x86_64/20160827-011727
> config: x86_64-randconfig-v0-08280034 (attached as .config)
> compiler: gcc-6 (Debian 6.1.1-9) 6.1.1 20160705
> reproduce:
>         # save the attached .config to linux build tree
>         make ARCH=x86_64
>
> All errors (new ones prefixed by >>):
>
>    arch/x86/built-in.o: In function `do_arch_prctl':
>>> (.text+0x29865): undefined reference to `vdso_image_32'
>    arch/x86/built-in.o: In function `do_arch_prctl':
>    (.text+0x29877): undefined reference to `vdso_image_32'
>
> ---
> 0-DAY kernel test infrastructure                Open Source Technology Center
> https://lists.01.org/pipermail/kbuild-all                   Intel Corporation
>

Right, that
+#if defined CONFIG_X86_32 || defined CONFIG_COMPAT
+	case ARCH_MAP_VDSO_32:
+		return prctl_map_vdso(&vdso_image_32, addr);
+#endif

should be:
#if defined CONFIG_X86_32 || defined CONFIG_IA32_EMULATION
// ...

will resend with this fixup.

-- 
              Dmitry