linux-kernel - Re: [PATCH] scsi: move function declarationes to scsi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <204f29e4-f582-5961-b62c-b0bf9de67b86@sandisk.com>
Date:   Mon, 29 Aug 2016 08:58:57 -0700
From:   Bart Van Assche <bart.vanassche@...disk.com>
To:     Baoyou Xie <baoyou.xie@...aro.org>, <jejb@...ux.vnet.ibm.com>,
        <martin.petersen@...cle.com>
CC:     <linux-scsi@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <arnd@...aro.org>, <xie.baoyou@....com.cn>
Subject: Re: [PATCH] scsi: move function declarationes to scsi_priv.h

On 08/27/2016 09:59 AM, Baoyou Xie wrote:
> We get 2 warnings about global functions without a declaration
> in the scsi driver when building with W=1:
> drivers/scsi/scsi_lib.c:467:6: warning: no previous prototype for 'scsi_requeue_run_queue' [-Wmissing-prototypes]
> drivers/scsi/scsi_lib.c:2609:6: warning: no previous prototype for 'scsi_evt_thread' [-Wmissing-prototypes]
>
> in fact, both functiones are declared in drivers/scsi/scsi_scan.c
> but need to move the declarationes into scsi_priv.h.

Please fix the spelling in the patch title and description (functiones 
-> functions and declarationes -> declarations). Anyway:

Reviewed-by: Bart Van Assche <bart.vanassche@...disk.com>