linux-kernel - Re: [PATCH V6 0/5] perf: Driver specific configuration for PMU

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANLsYkyzYaF3Z=MPAwevtosN-XU5BK7qSwppaJ1nBNqT-qoCwA@mail.gmail.com>
Date:   Mon, 29 Aug 2016 09:58:51 -0600
From:   Mathieu Poirier <mathieu.poirier@...aro.org>
To:     Jiri Olsa <jolsa@...hat.com>
Cc:     Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...hat.com>,
        Arnaldo Carvalho de Melo <acme@...nel.org>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        jolsa@...nel.org,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH V6 0/5] perf: Driver specific configuration for PMU

On 28 August 2016 at 08:18, Jiri Olsa <jolsa@...hat.com> wrote:
> On Thu, Aug 25, 2016 at 02:20:40PM -0600, Mathieu Poirier wrote:
>
> SNIP
>
>> perf record -e some_event/@...1,@cfg2=config/ ...
>>
>> The above are all valid configuration and will see the strings 'cfg1'
>> and 'cfg2=config' sent to the PMU driver for parsing and interpretation
>> using the existing ioctl() mechanism.
>>
>> The primary customers for this feature are the CoreSight drivers where
>> the selection of a sink (where trace data is accumulated) needs to be
>> done in a previous, and separated step, from the launching of the perf
>> command.
>>
>> As such something that used to be a two-step process:
>>
>> # echo 1 > /sys/bus/coresight/devices/20070000.etr/enable_sink
>> # perf record -e cs_etm//u --per-thread  uname
>>
>> is integrated in a single command:
>>
>> # perf record -e cs_etm/@...70000.etr/u --per-thread  uname
>>
>> Thanks,
>> Mathieu
>>
>> Changes for V6:
>> - Using sysFS rather than an ioctl() to communicate command line
>>   parameters to the CoreSight PMU.
>
> apart from few nits it looks good.. but can't say for patch 2/5 ;-)
>
> Acked-by: Jiri Olsa <jolsa@...nel.org>
>

Many thanks for taking the time to look at this set - your time is
much appreciated.

> thanks,
> jirka