linux-kernel - Re: [PATCH V6 1/5] perf tools: making coresight PMU listable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 31 Aug 2016 08:58:56 +0200
From:   Jiri Olsa <jolsa@...hat.com>
To:     Mathieu Poirier <mathieu.poirier@...aro.org>
Cc:     Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...hat.com>,
        Arnaldo Carvalho de Melo <acme@...nel.org>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        jolsa@...nel.org,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH V6 1/5] perf tools: making coresight PMU listable

On Mon, Aug 29, 2016 at 09:56:02AM -0600, Mathieu Poirier wrote:
> On 28 August 2016 at 08:16, Jiri Olsa <jolsa@...hat.com> wrote:
> > On Thu, Aug 25, 2016 at 02:20:41PM -0600, Mathieu Poirier wrote:
> >
> > SNIP
> >
> >>  ARM/CORGI MACHINE SUPPORT
> >>  M:   Richard Purdie <rpurdie@...ys.net>
> >> diff --git a/tools/perf/Makefile.config b/tools/perf/Makefile.config
> >> index 24803c58049a..72edf83d76b7 100644
> >> --- a/tools/perf/Makefile.config
> >> +++ b/tools/perf/Makefile.config
> >> @@ -746,10 +746,13 @@ ifdef LIBBABELTRACE
> >>  endif
> >>
> >>  ifndef NO_AUXTRACE
> >> -  ifeq ($(feature-get_cpuid), 0)
> >> -    msg := $(warning Your gcc lacks the __get_cpuid() builtin, disables support for auxtrace/Intel PT, please install a newer gcc);
> >> -    NO_AUXTRACE := 1
> >> -  else
> >> +  ifeq ($(ARCH),x86)
> >> +    ifeq ($(feature-get_cpuid), 0)
> >> +      msg := $(warning Your gcc lacks the __get_cpuid() builtin, disables support for auxtrace/Intel PT, please install a newer gcc);
> >> +      NO_AUXTRACE := 1
> >> +    endif
> >> +  endif
> >> +  ifndef NO_AUXTRACE
> >
> > hum, how's this hunk connected to the issue described in changelog?
> 
> Patch 1/6 and 2/6 are needed by [3, 4, 5, 6]/6 of this set.
> Originally they were part of a separate patchset I but decided to
> include them here for completeness.  Let me know if you'd like to see
> them split again.

ook, jirka