linux-kernel - Re: [PATCH 3/5] firmware: ti_sci: Add support for Device control

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 29 Aug 2016 15:30:18 -0700
From:   Santosh Shilimkar <santosh.shilimkar@...cle.com>
To:     Nishanth Menon <nm@...com>, Lokesh Vutla <lokeshvutla@...com>
Cc:     Russell King <rmk+kernel@...linux.org.uk>,
        Sudeep Holla <sudeep.holla@....com>,
        Santosh Shilimkar <ssantosh@...nel.org>,
        Tero Kristo <t-kristo@...com>, Dave Gerlach <d-gerlach@...com>,
        "linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>,
        lkml <linux-kernel@...r.kernel.org>,
        "Andrew F . Davis" <afd@...com>,
        dt list <devicetree@...r.kernel.org>,
        Russ Dill <Russ.Dill@...com>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH 3/5] firmware: ti_sci: Add support for Device control

Hi Nishant,

On 8/23/2016 11:45 AM, Nishanth Menon wrote:
> On Sun, Aug 21, 2016 at 10:56 PM, Lokesh Vutla <lokeshvutla@...com> wrote:
>>>  /**
>>> + * tis_sci_is_response_ack() - Generic ACK/NACK message checkup
>>> + * @r:       pointer to response buffer
>>> + *
>>> + * Return: true if the response was an ACK, else returns false.
>>> + */
>>> +static inline bool tis_sci_is_response_ack(void *r)
>>
>> May be just ti_sci_is_response_ack() to be consistent? or you wanted to
>> keep it tis_sci* ?
>
>
> Uggh.. Fat fingered that one.. thanks for catching.. fixed and will
> post a v2 next week if there is no further comments
>
I would like to send the next merge window queue up so please repost
the reviewed patches which needs to be queued up.

Regards,
Santosh