linux-kernel - Re: [PATCH] arch: all: include: asm: bitops: Use bool instead of int for all bit test functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <57C4B0C5.4050502@emindsoft.com.cn>
Date:   Tue, 30 Aug 2016 06:01:41 +0800
From:   Chen Gang <chengang@...ndsoft.com.cn>
To:     Arnd Bergmann <arnd@...db.de>
CC:     akpm@...ux-foundation.org, minchan@...nel.org, vbabka@...e.cz,
        gi-oh.kim@...fitbricks.com, iamjoonsoo.kim@....com,
        hillf.zj@...baba-inc.com, mgorman@...hsingularity.net,
        mhocko@...e.com, rientjes@...gle.com, linux-kernel@...r.kernel.org,
        rth@...ddle.net, ink@...assic.park.msu.ru, mattst88@...il.com,
        vgupta@...opsys.com, linux@...linux.org.uk,
        catalin.marinas@....com, will.deacon@....com,
        hskinnemoen@...il.com, egtvedt@...fundet.no, realmz6@...il.com,
        ysato@...rs.sourceforge.jp, rkuo@...eaurora.org,
        tony.luck@...el.com, fenghua.yu@...el.com, geert@...ux-m68k.org,
        james.hogan@...tec.com, ralf@...ux-mips.org, dhowells@...hat.com,
        deller@....de, benh@...nel.crashing.org, paulus@...ba.org,
        mpe@...erman.id.au, schwidefsky@...ibm.com,
        heiko.carstens@...ibm.com, dalias@...c.org, davem@...emloft.net,
        cmetcalf@...lanox.com, chris@...kel.net, jcmvbkbc@...il.com,
        noamc@...hip.com, brueckner@...ux.vnet.ibm.com, mingo@...nel.org,
        peterz@...radead.org, linux-arch@...r.kernel.org,
        Chen Gang <gang.chen.5i5j@...il.com>
Subject: Re: [PATCH] arch: all: include: asm: bitops: Use bool instead of
 int for all bit test functions


On 8/29/16 21:03, Arnd Bergmann wrote:
> On Sunday 28 August 2016, chengang@...ndsoft.com.cn wrote:
>> From: Chen Gang <chengang@...ndsoft.com.cn>
>>
>> Also use the same changing to asm-generic, and also use bool variable
>> instead of int variable for mips, mn10300, parisc and tile related
>> functions, and also avoid checkpatch.pl to report ERROR.
>>
>> Originally, except powerpc and xtensa, all another architectures intend
>> to return 0 or 1. After this patch, also let powerpc and xtensa return 0
>> or 1.
>>
>> The patch passes cross building for mips and parisc with default config.
>> All related contents are found by "grep test_bit, grep test_and" under
>> arch sub-directory.
>>
>> Signed-off-by: Chen Gang <gang.chen.5i5j@...il.com>
> 
> This seems like a good idea overall, and I'm fine with the asm-generic
> contents. If there is consensus on changing this, we probably also want
> to do some other steps:
> 
> - Change the Documentation/atomic_ops.txt file accordingly
> - split up the series per architecture (I don't think there are any
>   interdependencies)
> - For the architectures on which the definition changes (at least
>   x86 and ARM), do some more sanity checks and see if there are
>   noticeable changes in object code, and if so whether it looks
>   better or worse (I'm guessing it will be better if anything)
> - See which architectures can still get converted to using the
>   asm-generic headers instead of providing their own, I think at
>   least for the nonatomic ones, there are a couple.
> 

Thank you for your ideas, suggestions, and completions.

And I guess, at least for arc, I or another related members will try to
check the object code.


Thanks.
-- 
Chen Gang (陈刚)

Managing Natural Environments is the Duty of Human Beings.