linux-kernel - Re: [PATCH 1/9] ARM: dts: exynos: Add macros for GPIO configuration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <28320955.k33BrW2NEN@wuerfel>
Date:   Wed, 31 Aug 2016 14:42:57 +0200
From:   Arnd Bergmann <arnd@...db.de>
To:     linux-arm-kernel@...ts.infradead.org
Cc:     Krzysztof Kozlowski <k.kozlowski@...sung.com>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Kukjin Kim <kgene@...nel.org>,
        Krzysztof Kozlowski <krzk@...nel.org>,
        devicetree@...r.kernel.org, linux-samsung-soc@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Javier Martinez Canillas <javier@....samsung.com>,
        Tomasz Figa <tomasz.figa@...il.com>,
        Sylwester Nawrocki <s.nawrocki@...sung.com>,
        Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>
Subject: Re: [PATCH 1/9] ARM: dts: exynos: Add macros for GPIO configuration

On Wednesday, August 31, 2016 2:13:25 PM CEST Krzysztof Kozlowski wrote:
> 
> +#define PIN_PULL_NONE          0
> +#define PIN_PULL_DOWN          1
> +#define PIN_PULL_UP            3
> +
> +#define PIN_DRV_LV1            0
> +#define PIN_DRV_LV2            2
> +#define PIN_DRV_LV3            1
> +#define PIN_DRV_LV4            3
> +
> +#define PIN_FUNC_INPUT         0
> +#define PIN_FUNC_OUTPUT                1
> +#define PIN_FUNC_SPC_2         2
> +#define PIN_FUNC_SPC_3         3
> +#define PIN_FUNC_SPC_4         4
> +#define PIN_FUNC_SPC_5         5
> +#define PIN_FUNC_SPC_F         0xf

Any reason for having a copy in each of those files instead of one
that is shared across all of them?

	Arnd