linux-kernel - Re: [PATCH] parisc: led: Remove deprecated create_singlethread

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160831140556.GF12660@htj.duckdns.org>
Date:   Wed, 31 Aug 2016 10:05:56 -0400
From:   Tejun Heo <tj@...nel.org>
To:     Bhaktipriya Shridhar <bhaktipriya96@...il.com>
Cc:     "James E.J. Bottomley" <jejb@...isc-linux.org>,
        Helge Deller <deller@....de>, linux-parisc@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] parisc: led: Remove deprecated
 create_singlethread_workqueue

On Tue, Aug 30, 2016 at 10:03:43PM +0530, Bhaktipriya Shridhar wrote:
> The workqueue "led_wq" queues a single work item &led_task and hence
> doesn't require ordering. It is involved in managing when and which
> chassis LCD/LED gets updated and hence, is not being used on a memory
> reclaim path. Hence, it has been converted to use system_wq.
> 
> System workqueues have been able to handle high level of concurrency
> for a long time now and hence it's not required to have a singlethreaded
> workqueue just to gain concurrency. Unlike a dedicated per-cpu workqueue
> created with create_singlethread_workqueue(), system_wq allows multiple
> work items to overlap executions even on the same CPU; however, a
> per-cpu workqueue doesn't have any CPU locality or global ordering
> guarantee unless the target CPU is explicitly specified and thus the
> increase of local concurrency shouldn't make any difference.
> 
> The work item has been sync cancelled in led_halt to ensure that
> there are no pending tasks while disconnecting the driver.
> 
> Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@...il.com>

Acked-by: Tejun Heo <tj@...nel.org>

Thanks.

-- 
tejun