linux-kernel - Re: [PATCH] rsxx: Remove deprecated create_singlethread

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160831140630.GG12660@htj.duckdns.org>
Date:   Wed, 31 Aug 2016 10:06:30 -0400
From:   Tejun Heo <tj@...nel.org>
To:     Bhaktipriya Shridhar <bhaktipriya96@...il.com>
Cc:     Joshua Morris <josh.h.morris@...ibm.com>,
        Philip Kelleher <pjk1939@...ux.vnet.ibm.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] rsxx: Remove deprecated create_singlethread_workqueue

On Tue, Aug 30, 2016 at 10:04:28PM +0530, Bhaktipriya Shridhar wrote:
> The workqueue "creg_wq" queues a single work item viz
> &card->creg_ctrl.done_work and hence it doesn't require execution
> ordering. Hence, alloc_workqueue has been used to replace the
> deprecated create_singlethread_workqueue instance.
> 
> The workqueue "event_wq" queues a single work item viz &card->event_work
> and hence it doesn't require execution ordering. Hence, alloc_workqueue
> has been used to replace the deprecated create_singlethread_workqueue
> instance.
> 
> The WQ_MEM_RECLAIM flag has been set in both cases to ensure forward
> progress under memory pressure.
> 
> Since there are a fixed number of work items, explicit concurrency
> limit is unnecessary here.
> 
> Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@...il.com>

Acked-by: Tejun Heo <tj@...nel.org>

Thanks.

-- 
tejun