linux-kernel - Re: [PATCH] s390: Remove deprecated create_singlethread

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160831143110.GT12660@htj.duckdns.org>
Date:   Wed, 31 Aug 2016 10:31:10 -0400
From:   Tejun Heo <tj@...nel.org>
To:     Bhaktipriya Shridhar <bhaktipriya96@...il.com>
Cc:     Martin Schwidefsky <schwidefsky@...ibm.com>,
        Heiko Carstens <heiko.carstens@...ibm.com>,
        Steffen Maier <maier@...ux.vnet.ibm.com>,
        linux-s390@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] s390: Remove deprecated create_singlethread_workqueue

On Wed, Aug 31, 2016 at 01:57:20AM +0530, Bhaktipriya Shridhar wrote:
> The workqueue "appldata_wq" has been replaced with an ordered dedicated
> workqueue.
> 
> WQ_MEM_RECLAIM has not been set since the workqueue is not being used on
> a memory reclaim path.
> 
> The adapter->work_queue queues multiple work items viz
> &adapter->scan_work, &port->rport_work, &adapter->ns_up_work,
> &adapter->stat_work, adapter->work_queue, &adapter->events.work,
> &port->gid_pn_work, &port->test_link_work. Hence, an ordered
> dedicated workqueue has been used.
> 
> WQ_MEM_RECLAIM has been set to ensure forward progress under memory
> pressure.

I have no idea what these drivers do.  s390 folks, can you please shed
some light on whether these workqueues can be depended on during
memory reclaim?

Thanks.

-- 
tejun