linux-kernel - Re: [PATCH] s390: Remove deprecated create_singlethread

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160903105334.GA3917@osiris>
Date:   Sat, 3 Sep 2016 12:53:34 +0200
From:   Heiko Carstens <heiko.carstens@...ibm.com>
To:     Tejun Heo <tj@...nel.org>
Cc:     Bhaktipriya Shridhar <bhaktipriya96@...il.com>,
        Martin Schwidefsky <schwidefsky@...ibm.com>,
        Steffen Maier <maier@...ux.vnet.ibm.com>,
        linux-s390@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] s390: Remove deprecated create_singlethread_workqueue

On Wed, Aug 31, 2016 at 10:31:10AM -0400, Tejun Heo wrote:
> On Wed, Aug 31, 2016 at 01:57:20AM +0530, Bhaktipriya Shridhar wrote:
> > The workqueue "appldata_wq" has been replaced with an ordered dedicated
> > workqueue.
> > 
> > WQ_MEM_RECLAIM has not been set since the workqueue is not being used on
> > a memory reclaim path.
> > 
> > The adapter->work_queue queues multiple work items viz
> > &adapter->scan_work, &port->rport_work, &adapter->ns_up_work,
> > &adapter->stat_work, adapter->work_queue, &adapter->events.work,
> > &port->gid_pn_work, &port->test_link_work. Hence, an ordered
> > dedicated workqueue has been used.
> > 
> > WQ_MEM_RECLAIM has been set to ensure forward progress under memory
> > pressure.
> 
> I have no idea what these drivers do.  s390 folks, can you please shed
> some light on whether these workqueues can be depended on during
> memory reclaim?

The appldata device driver is only needed to gather statistical data and
therefore my wait when memory reclaim is in progress.

The zfcp device drivers is a SCSI-over-FC device driver and hence we depend
on it during memory reclaim. So setting WQ_MEM_RECLAIM is the right thing
to do here.

The patch looks ok, and I applied it.

Thanks!