linux-kernel - RE: [PATCH 1/4] Drivers: hv: cleanup vmbus

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 31 Aug 2016 17:55:46 +0000
From:   KY Srinivasan <kys@...rosoft.com>
To:     Greg KH <gregkh@...uxfoundation.org>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "devel@...uxdriverproject.org" <devel@...uxdriverproject.org>,
        "olaf@...fle.de" <olaf@...fle.de>,
        "apw@...onical.com" <apw@...onical.com>,
        "vkuznets@...hat.com" <vkuznets@...hat.com>,
        "jasowang@...hat.com" <jasowang@...hat.com>,
        "leann.ogasawara@...onical.com" <leann.ogasawara@...onical.com>
Subject: RE: [PATCH 1/4] Drivers: hv: cleanup vmbus_open() for wrap around
 mappings



> -----Original Message-----
> From: Greg KH [mailto:gregkh@...uxfoundation.org]
> Sent: Wednesday, August 31, 2016 4:13 PM
> To: KY Srinivasan <kys@...rosoft.com>
> Cc: linux-kernel@...r.kernel.org; devel@...uxdriverproject.org;
> olaf@...fle.de; apw@...onical.com; vkuznets@...hat.com;
> jasowang@...hat.com; leann.ogasawara@...onical.com
> Subject: Re: [PATCH 1/4] Drivers: hv: cleanup vmbus_open() for wrap around
> mappings
> 
> On Wed, Jul 06, 2016 at 05:25:02PM -0700, kys@...hange.microsoft.com
> wrote:
> > From: Vitaly Kuznetsov <vkuznets@...hat.com>
> >
> > In preparation for doing wrap around mappings for ring buffers cleanup
> > vmbus_open() function:
> > - check that ring sizes are PAGE_SIZE aligned (they are for all in-kernel
> >   drivers now);
> > - kfree(open_info) on error only after we kzalloc() it (not an issue as it
> >   is valid to call kfree(NULL);
> > - rename poorly named labels;
> > - use alloc_pages() instead of __get_free_pages() as we need struct page
> >   pointer for future.
> >
> > Signed-off-by: Vitaly Kuznetsov <vkuznets@...hat.com>
> > Signed-off-by: K. Y. Srinivasan <kys@...rosoft.com>
> > Tested-by: Dexuan Cui <decui@...rosoft.com>
> > ---
> >  drivers/hv/channel.c |   43 +++++++++++++++++++++++--------------------
> >  1 files changed, 23 insertions(+), 20 deletions(-)
> 
> This patch doesn't apply to the tree due to the other hv patches you
> sent.  Can you respin this series and resend?

Will do.

Regards,

K. Y
> 
> thanks,
> 
> greg k-h