linux-kernel - Re: [PATCH 1/9] staging: sm750fb: fix line length coding style issue in ddk750

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJEcRgqM=gLmFVkCY78gkqHDV8jU2i8ST37s8NkjJ77CoxeZrw@mail.gmail.com>
Date:   Fri, 2 Sep 2016 11:28:51 +0300
From:   moshe green <mgmoshes@...il.com>
To:     Greg KH <gregkh@...uxfoundation.org>
Cc:     Sudip Mukherjee <sudipm.mukherjee@...il.com>,
        teddy.wang@...iconmotion.com, devel@...verdev.osuosl.org,
        linux-fbdev@...r.kernel.org,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/9] staging: sm750fb: fix line length coding style issue
 in ddk750_chip.c

There were (mostly) two kinds of warnings that I've handled, "80
character line length" and block comments structure.
Some of the changes involve handling two separate warnings in a single comment.
Where this occurs, should I break down the change into two steps -
fixing a warning at a time?
Or should I fix both warnings in the same commit - and place the
commit in the most appropriate patch?
thanks

Moshe Green

On 1 September 2016 at 19:04, Greg KH <gregkh@...uxfoundation.org> wrote:
> On Tue, Aug 30, 2016 at 10:04:02PM +0300, Moshe Green wrote:
>> Fix a line length warning found by the checkpatch.pl tool in
>> ddk750_chip.c.
>>
>> Signed-off-by: Moshe Green <mgmoshes@...il.com>
>> ---
>>  drivers/staging/sm750fb/ddk750_chip.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> Lots of the patches in this series have the same exact subject: line,
> yet they do different things.  Please fix them up and make them more
> obvious, or even better yet, merge them into less patches (one type of
> thing per file per patch, not one single change per patch).
>
> thanks,
>
> greg k-h