linux-kernel - Re: [PATCH 1/9] staging: sm750fb: fix line length coding style issue in ddk750

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160902113508.GA18456@kroah.com>
Date:   Fri, 2 Sep 2016 13:35:08 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     moshe green <mgmoshes@...il.com>
Cc:     devel@...verdev.osuosl.org,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        linux-fbdev@...r.kernel.org,
        Sudip Mukherjee <sudipm.mukherjee@...il.com>,
        teddy.wang@...iconmotion.com
Subject: Re: [PATCH 1/9] staging: sm750fb: fix line length coding style issue
 in ddk750_chip.c


A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?
A: Top-posting.
Q: What is the most annoying thing in e-mail?

A: No.
Q: Should I include quotations after my reply?


http://daringfireball.net/2007/07/on_top

On Fri, Sep 02, 2016 at 11:28:51AM +0300, moshe green wrote:
> There were (mostly) two kinds of warnings that I've handled, "80
> character line length" and block comments structure.
> Some of the changes involve handling two separate warnings in a single comment.
> Where this occurs, should I break down the change into two steps -
> fixing a warning at a time?
> Or should I fix both warnings in the same commit - and place the
> commit in the most appropriate patch?

Hm, use your best judgement here, what would you want to be on the
receiving end of if you had to review such a patch series?

thanks,

greg k-h