[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <d8689621-2dc3-ccf8-c33b-68f0d6eab66b@huawei.com>
Date: Mon, 5 Sep 2016 19:11:59 +0800
From: Yisheng Xie <xieyisheng1@...wei.com>
To: Will Deacon <will.deacon@....com>
CC: <mingo@...nel.org>, <guohanjun@...wei.com>, <mark.rutland@....com>,
<catalin.marinas@....com>, <linux-kernel@...r.kernel.org>,
<linux-arm-kernel@...ts.infradead.org>, <matt@...eblueprint.co.uk>,
<linux-efi@...r.kernel.org>, <ard.biesheuvel@...aro.org>
Subject: Re: [PATCH] arm64/efi: efi_init error handling fix
Hi all,
Could someone help to give some comments?
Really thanks for that.
Thanks.
Xie Yisheng
On 2016/9/2 18:26, Will Deacon wrote:
> On Fri, Sep 02, 2016 at 06:18:39PM +0800, Xie Yisheng wrote:
>> From: Yisheng Xie <xieyisheng1@...wei.com>
>>
>> There's an early memmap leak in efi_init error path, fix it.
>>
>> Signed-off-by: Yisheng Xie <xieyisheng1@...wei.com>
>> ---
>> drivers/firmware/efi/arm-init.c | 4 +++-
>> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> Adding linux-efi, Ard and Matt. Please try to CC the relevant people in
> future.
>
Hi Will,
Thank you for your kind help. I will do more check about who to CC next time.
Thanks.
> Will
>
>> diff --git a/drivers/firmware/efi/arm-init.c b/drivers/firmware/efi/arm-init.c
>> index c49d50e..5080e40 100644
>> --- a/drivers/firmware/efi/arm-init.c
>> +++ b/drivers/firmware/efi/arm-init.c
>> @@ -243,8 +243,10 @@ void __init efi_init(void)
>> "Unexpected EFI_MEMORY_DESCRIPTOR version %ld",
>> efi.memmap.desc_version);
>>
>> - if (uefi_init() < 0)
>> + if (uefi_init() < 0) {
>> + early_memunmap(efi.memmap.map, params.mmap_size);
>> return;
>> + }
>>
>> reserve_regions();
>> efi_memattr_init();
>> --
>> 1.7.12.4
>>
>
> .
>
Powered by blists - more mailing lists