linux-kernel - Re: [PATCH] arm64/efi: efi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160905135723.GK32579@codeblueprint.co.uk>
Date:   Mon, 5 Sep 2016 14:57:23 +0100
From:   Matt Fleming <matt@...eblueprint.co.uk>
To:     Will Deacon <will.deacon@....com>
Cc:     Xie Yisheng <xieyisheng1@...wei.com>, mingo@...nel.org,
        guohanjun@...wei.com, mark.rutland@....com,
        catalin.marinas@....com, linux-kernel@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-efi@...r.kernel.org,
        ard.biesheuvel@...aro.org
Subject: Re: [PATCH] arm64/efi: efi_init error handling fix

On Fri, 02 Sep, at 11:26:18AM, Will Deacon wrote:
> On Fri, Sep 02, 2016 at 06:18:39PM +0800, Xie Yisheng wrote:
> > From: Yisheng Xie <xieyisheng1@...wei.com>
> > 
> > There's an early memmap leak in efi_init error path, fix it.
> > 
> > Signed-off-by: Yisheng Xie <xieyisheng1@...wei.com>
> > ---
> >  drivers/firmware/efi/arm-init.c | 4 +++-
> >  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> Adding linux-efi, Ard and Matt. Please try to CC the relevant people in
> future.
> 
> Will
> 
> > diff --git a/drivers/firmware/efi/arm-init.c b/drivers/firmware/efi/arm-init.c
> > index c49d50e..5080e40 100644
> > --- a/drivers/firmware/efi/arm-init.c
> > +++ b/drivers/firmware/efi/arm-init.c
> > @@ -243,8 +243,10 @@ void __init efi_init(void)
> >  	     "Unexpected EFI_MEMORY_DESCRIPTOR version %ld",
> >  	      efi.memmap.desc_version);
> >  
> > -	if (uefi_init() < 0)
> > +	if (uefi_init() < 0) {
> > +		early_memunmap(efi.memmap.map, params.mmap_size);
> >  		return;
> > +	}

This should be a call to efi_memmap_unmap() because the EFI_MEMMAP
flag also needs clearing.