linux-kernel - Re: [PATCH v2] ubifs: compress lines for immediate return

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <71387535-39e5-9cbc-71c4-d5142e409110@sigma-star.at>
Date:   Mon, 5 Sep 2016 15:18:40 +0200
From:   David Oberhollenzer <david.oberhollenzer@...ma-star.at>
To:     Heiko Schocher <hs@...x.de>, linux-mtd@...ts.infradead.org
Cc:     Artem Bityutskiy <dedekind1@...il.com>,
        Richard Weinberger <richard@....at>,
        Adrian Hunter <adrian.hunter@...el.com>,
        linux-kernel@...r.kernel.org,
        Masahiro Yamada <yamada.masahiro@...ionext.com>
Subject: Re: [PATCH v2] ubifs: compress lines for immediate return

On 09/05/2016 08:54 AM, Heiko Schocher wrote:
> diff --git a/fs/ubifs/budget.c b/fs/ubifs/budget.c
> index 11a11b3..48d6851 100644
> --- a/fs/ubifs/budget.c
> +++ b/fs/ubifs/budget.c
> @@ -77,7 +77,7 @@ static void shrink_liability(struct ubifs_info *c, int nr_to_write)
>   */
>  static int run_gc(struct ubifs_info *c)
>  {
> -	int err, lnum;
> +	int lnum;
>  
>  	/* Make some free space by garbage-collecting dirty space */
>  	down_read(&c->commit_sem);
> @@ -88,10 +88,7 @@ static int run_gc(struct ubifs_info *c)
>  
>  	/* GC freed one LEB, return it to lprops */
>  	dbg_budg("GC freed LEB %d", lnum);
> -	err = ubifs_return_leb(c, lnum);
> -	if (err)
> -		return err;
> -	return 0;
> +	return = ubifs_return_leb(c, lnum);
>  }
>  

Apart from the other issues discussed below and in v1, I don't
believe that this _ever_ compiled successfully.