linux-kernel - Re: [PATCH 1/2] Staging: comedi: ni_daq_dio24.c: Fix block comments use * on subsequent lines.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CALRcH8B73BOK=w9=boq18daKQTZBNp2DcLYkThG3mBbJfzZj+Q@mail.gmail.com>
Date:   Mon, 5 Sep 2016 19:43:28 +0530
From:   Amit Ghadge <amitg.b14@...il.com>
To:     Ian Abbott <abbotti@....co.uk>
Cc:     Greg KH <gregkh@...uxfoundation.org>, devel@...verdev.osuosl.org,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/2] Staging: comedi: ni_daq_dio24.c: Fix block comments
 use * on subsequent lines.

On Mon, Sep 5, 2016 at 6:45 PM, Ian Abbott <abbotti@....co.uk> wrote:
> On 03/09/16 21:11, Amit Ghadge wrote:
>>
>> This is a patch to the ni_daq_dio24.c that fixes checkpatch warning:
>>
>> WARNING: Block comments use * on subsequent lines
>>
>> Signed-off-by: Amit Ghadge <amitg.b14@...il.com>
>> ---
>>  drivers/staging/comedi/drivers/ni_daq_dio24.c | 52
>> +++++++++++++--------------
>>  1 file changed, 26 insertions(+), 26 deletions(-)
>>
>> diff --git a/drivers/staging/comedi/drivers/ni_daq_dio24.c
>> b/drivers/staging/comedi/drivers/ni_daq_dio24.c
>> index d9de83a..ff3716c 100644
>> --- a/drivers/staging/comedi/drivers/ni_daq_dio24.c
>> +++ b/drivers/staging/comedi/drivers/ni_daq_dio24.c
>> @@ -1,35 +1,35 @@
>>  /*
>> -    comedi/drivers/ni_daq_dio24.c
>> -    Driver for National Instruments PCMCIA DAQ-Card DIO-24
>> -    Copyright (C) 2002 Daniel Vecino Castel <dvecino@...e.es>
>> + * comedi/drivers/ni_daq_dio24.c
>> + * Driver for National Instruments PCMCIA DAQ-Card DIO-24
>> + * Copyright (C) 2002 Daniel Vecino Castel <dvecino@...e.es>
>>
>> -    PCMCIA crap at end of file is adapted from dummy_cs.c 1.31
>> -    2001/08/24 12:13:13 from the pcmcia package.
>> -    The initial developer of the pcmcia dummy_cs.c code is David A. Hinds
>> -    <dahinds@...rs.sourceforge.net>.  Portions created by David A. Hinds
>> -    are Copyright (C) 1999 David A. Hinds.  All Rights Reserved.
>> + * PCMCIA crap at end of file is adapted from dummy_cs.c 1.31
>> + * 2001/08/24 12:13:13 from the pcmcia package.
>> + * The initial developer of the pcmcia dummy_cs.c code is David A. Hinds
>> + * <dahinds@...rs.sourceforge.net>.  Portions created by David A. Hinds
>> + * are Copyright (C) 1999 David A. Hinds.  All Rights Reserved.
>>
>> -    This program is free software; you can redistribute it and/or modify
>> -    it under the terms of the GNU General Public License as published by
>> -    the Free Software Foundation; either version 2 of the License, or
>> -    (at your option) any later version.
>> + * This program is free software; you can redistribute it and/or modify
>> + * it under the terms of the GNU General Public License as published by
>> + * the Free Software Foundation; either version 2 of the License, or
>> + * (at your option) any later version.
>>
>> -    This program is distributed in the hope that it will be useful,
>> -    but WITHOUT ANY WARRANTY; without even the implied warranty of
>> -    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
>> -    GNU General Public License for more details.
>> -*/
>> + * This program is distributed in the hope that it will be useful,
>> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
>> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
>> + * GNU General Public License for more details.
>> + */
>
>
> The blank lines in that comment block should also have the " *" so it has an
> unbroken, vertical line of "*" down the left side of the comment block.
>
>>  /*
>> -Driver: ni_daq_dio24
>> -Description: National Instruments PCMCIA DAQ-Card DIO-24
>> -Author: Daniel Vecino Castel <dvecino@...e.es>
>> -Devices: [National Instruments] PCMCIA DAQ-Card DIO-24 (ni_daq_dio24)
>> -Status: ?
>> -Updated: Thu, 07 Nov 2002 21:53:06 -0800
>> + * Driver: ni_daq_dio24
>> + * Description: National Instruments PCMCIA DAQ-Card DIO-24
>> + * Author: Daniel Vecino Castel <dvecino@...e.es>
>> + * Devices: [National Instruments] PCMCIA DAQ-Card DIO-24 (ni_daq_dio24)
>> + * Status: ?
>> + * Updated: Thu, 07 Nov 2002 21:53:06 -0800
>>
>> -This is just a wrapper around the 8255.o driver to properly handle
>> -the PCMCIA interface.
>> -*/
>> + * This is just a wrapper around the 8255.o driver to properly handle
>> + * the PCMCIA interface.
>> + */
>
>
> Same thing there.
>
> --
> -=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti@....co.uk> )=-
> -=(                          Web: http://www.mev.co.uk/  )=-


I will be send updated patch.

Amit G