linux-kernel - Re: [PATCH] ubifs: compress lines for immediate return

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <57CD1239.6060105@denx.de>
Date:   Mon, 5 Sep 2016 08:35:37 +0200
From:   Heiko Schocher <hs@...x.de>
To:     Richard Weinberger <richard@....at>
Cc:     linux-mtd@...ts.infradead.org,
        Artem Bityutskiy <dedekind1@...il.com>,
        Adrian Hunter <adrian.hunter@...el.com>,
        Masahiro Yamada <yamada.masahiro@...ionext.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ubifs: compress lines for immediate return

Hello Richard,

Am 05.09.2016 um 08:28 schrieb Richard Weinberger:
> Heiko,
>
> On 05.09.2016 06:59, Heiko Schocher wrote:
>> fix the following code:
>>
>> -ret = expression;
>> -if (ret)
>> -        return ret;
>> -return 0;
>> +return expression;
>
> "Fix"? ;-)
> What was broken?

Ok, fix is to hard spoken ... nothing broken, sorry for confusing!

> I agree that we can write the expression in a different way, but is it really worth it?

I think yes ...

> Is this part of a tree-wide cleanup?

Yes, and I thought it is worth to change this part in linux too.

bye,
Heiko
-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany