linux-kernel - Re: [PATCH] ubifs: compress lines for immediate return

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <94271caf-4852-1d08-c6a0-102aac22ab65@nod.at>
Date:   Mon, 5 Sep 2016 00:28:05 -0600
From:   Richard Weinberger <richard@....at>
To:     Heiko Schocher <hs@...x.de>, <linux-mtd@...ts.infradead.org>
CC:     Artem Bityutskiy <dedekind1@...il.com>,
        "Hunter, Adrian" <adrian.hunter@...el.com>,
        Masahiro Yamada <yamada.masahiro@...ionext.com>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ubifs: compress lines for immediate return

Heiko,

On 05.09.2016 06:59, Heiko Schocher wrote:
> fix the following code:
> 
> -ret = expression;
> -if (ret)
> -        return ret;
> -return 0;
> +return expression;

"Fix"? ;-)
What was broken?

I agree that we can write the expression in a different way, but is it really worth it?
Is this part of a tree-wide cleanup?

Thanks,
//richard