linux-kernel - Re: [PATCH v3 2/2] arm64: dts: rockchip: support the pmu node for rk3399

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1666797.JgSRLN1JIq@phil>
Date:   Tue, 06 Sep 2016 00:27:09 +0200
From:   Heiko Stuebner <heiko@...ech.de>
To:     Caesar Wang <wxt@...k-chips.com>
Cc:     linux-rockchip@...ts.infradead.org,
        Douglas Anderson <dianders@...omium.org>,
        sonnyrao@...omium.org, linux-arm-kernel@...ts.infradead.org,
        Marc Zyngier <marc.zyngier@....com>,
        devicetree@...r.kernel.org, David Wu <david.wu@...k-chips.com>,
        Elaine Zhang <zhangqing@...k-chips.com>,
        Brian Norris <briannorris@...omium.org>,
        linux-kernel@...r.kernel.org, Shawn Lin <shawn.lin@...k-chips.com>,
        Will Deacon <will.deacon@....com>,
        Jianqun Xu <jay.xu@...k-chips.com>,
        Mark Rutland <mark.rutland@....com>,
        Rob Herring <robh+dt@...nel.org>,
        Catalin Marinas <catalin.marinas@....com>,
        Xing Zheng <zhengxing@...k-chips.com>
Subject: Re: [PATCH v3 2/2] arm64: dts: rockchip: support the pmu node for rk3399

Am Dienstag, 6. September 2016, 02:17:15 CEST schrieb Caesar Wang:
> This patch adds to enable the ARM Performance Monitor Units for rk3399.
> ARM cores often have a PMU for counting cpu and cache events like cache
> misses and hits.
> 
> Also, as the Marc posted the patches [0] to support Partitioning per-cpu
> interrupts. Let's add this patch to match it on rk3399 SoCs.
> 
> [0]:
> https://lkml.org/lkml/2016/4/11/182
> 
> Signed-off-by: Caesar Wang <wxt@...k-chips.com>
> Acked-by: Mark Rutland <mark.rutland@....com>
> Cc: Heiko Stuebner <heiko@...ech.de>
> Cc: Marc Zyngier <marc.zyngier@....com>
> CC: linux-arm-kernel@...ts.infradead.org

I've applied this one but did some corrections [0]:

- ppi-partitions is supposed to be a subnode of the gic, that is why the code
also start search for it starting from the gic node - I've moved it
- I've renamed the phandles taking part0/part1 from the example feels a bit to
generic, so it's now ppi_cluster0 and ppi_cluster1 matching the cpu-clusters

I've gave this a spin on my rk3399evb and the ppi-partitions got recognized
as well as the pmu instances got created, but please also double check again.


Thanks
Heiko


[0] https://git.kernel.org/cgit/linux/kernel/git/mmind/linux-rockchip.git/
commit/?id=48120b1af6f072bfd6b075bf9be560ad6fda2faa