linux-kernel - Re: [PATCH 4/7] serial: 8250

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <564d5aa9-6cde-2bac-afe2-39956caa93f7@gmail.com>
Date:   Tue, 6 Sep 2016 09:56:19 +0800
From:   "Ji-Ze Hong (Peter Hong)" <hpeter@...il.com>
To:     Ricardo Ribalda Delgado <ricardo.ribalda@...il.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     Jiri Slaby <jslaby@...e.com>, Arnd Bergmann <arnd@...db.de>,
        Peter Hurley <peter@...leysoftware.com>,
        linux-serial@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>,
        PA20 TOM TSAI 蔡宗佑 
        <tom_tsai@...tek.com.tw>, Peter H <peter_hong@...tek.com.tw>,
        "Ji-Ze Hong (Peter Hong)" <hpeter+linux_kernel@...il.com>
Subject: Re: [PATCH 4/7] serial: 8250_fintek: Rearrange function

Hi Ricardo, Greg,

Ricardo Ribalda Delgado 於 2016/9/1 下午 07:17 寫道:
> On one previous patch you almost rewrote theset_irq_mode function and
> added the prototype. It might be a good moment to move the whole
> function up.
>

I had try with merge the following 2 patches in local,
  1: serial: 8250_fintek: Set IRQ Mode when port probed
  2: serial: 8250_fintek: Rearrange function

but it made the patch less readable. So I'll try to add
set_irq() with prototype first, and change this function location
with other patch.

Could you give me some comments, Greg? Should I merge it?

Thanks
-- 
With Best Regards,
Peter Hong