linux-kernel - Re: [PATCH 3/7] serial: 8250_fintek: Set maximum FIFO of F81216H

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <bc53ebae-1f0a-b7ff-90b3-4dfb6278da5f@gmail.com>
Date:   Tue, 6 Sep 2016 09:37:58 +0800
From:   "Ji-Ze Hong (Peter Hong)" <hpeter@...il.com>
To:     Ricardo Ribalda Delgado <ricardo.ribalda@...il.com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Jiri Slaby <jslaby@...e.com>, Arnd Bergmann <arnd@...db.de>,
        Peter Hurley <peter@...leysoftware.com>,
        linux-serial@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>,
        PA20 TOM TSAI 蔡宗佑 
        <tom_tsai@...tek.com.tw>, Peter H <peter_hong@...tek.com.tw>,
        "Ji-Ze Hong (Peter Hong)" <hpeter+linux_kernel@...il.com>
Subject: Re: [PATCH 3/7] serial: 8250_fintek: Set maximum FIFO of F81216H

Hi Ricardo,

Ricardo Ribalda Delgado 於 2016/9/1 下午 07:16 寫道:
>> +static void fintek_8250_set_max_fifo(struct fintek_8250 *pdata)
>> +{
>> +       switch (pdata->pid) {
>> +       default: /* Default 16Bytes FIFO */
>> +               return;
>> +
>> +       case CHIP_ID_F81216H: /* 128Bytes FIFO */
>> +               sio_write_mask_reg(pdata, FIFO_CTRL,
>> +                                  FIFO_MODE_MASK | RXFTHR_MODE_MASK,
>> +                                  FIFO_MODE_128 | RXFTHR_MODE_4X);
>> +               break;
>> +       }
>
> I think it is more clear to have the default case as the ast one;

OK, I'll modify all default label to the last one.

>> +}
>> +
>>  static int find_base_port(struct fintek_8250 *pdata, u16 io_address,
>>                           unsigned int irq)
>
> I think that we should rename find_base_port to something else like
> probe_setup_port(),  we are not only finding the port but also setting
> it up.
>

OK, I'll modify it with next version.

-- 
With Best Regards,
Peter Hong